Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "mount failed: File exists" issue when unmount fails #4393

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Fix "mount failed: File exists" issue when unmount fails #4393

merged 2 commits into from
Jun 19, 2019

Conversation

fenglixa
Copy link
Contributor

The fixes including: a) fix above error b) delete corpse processes before unmount.

  • My UT cases: PASS
    case-1: a) minikube mount b) minikube ssh; cd c) Ctrl+c d) 'minikube mount' again.
    case-2: a) minikube mount b) minikube ssh; run script under mount point dir c) Ctrl+c d) 'minikube mount' again.

/assign @tstromberg
Could you please help review? Thanks.

@k8s-ci-robot
Copy link
Contributor

Welcome @fenglixa!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @fenglixa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@fenglixa fenglixa changed the title fix issue 4239 Fix "mount failed: File exists" issue May 31, 2019
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fenglixa
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tstromberg

If they are not already assigned, you can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2019
@fenglixa
Copy link
Contributor Author

fenglixa commented Jun 2, 2019

Append UT Result:
image
image

@fenglixa fenglixa mentioned this pull request Jun 3, 2019
Closed
@RA489
Copy link

RA489 commented Jun 3, 2019

@minikube-bot ok-to-test

@sharifelgamal
Copy link
Collaborator

@minikube-bot OK to test

1 similar comment
@fenglixa
Copy link
Contributor Author

@minikube-bot OK to test

@fenglixa
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@fenglixa: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RA489
Copy link

RA489 commented Jun 10, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2019
@medyagh
Copy link
Member

medyagh commented Jun 15, 2019

/retest this please

@fenglixa
Copy link
Contributor Author

test timed out after 1h15m0s
/retest please

@fenglixa
Copy link
Contributor Author

It cannot work when I call "/retest" to trigger integration test. Could anyone (member) help on this?
Thanks very much.

@RA489
Copy link

RA489 commented Jun 19, 2019

/retest

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

FYI - minikube has not moved to prow yet, so /retest does not work. We're still stuck on the old-style Jenkins commands.

@tstromberg tstromberg changed the title Fix "mount failed: File exists" issue Fix "mount failed: File exists" issue when unmount fails Jun 19, 2019
@tstromberg tstromberg merged commit b3c7496 into kubernetes:master Jun 19, 2019
@fenglixa fenglixa mentioned this pull request Jun 26, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat Awaiting requested review from balopat

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees

@tstromberg tstromberg

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fenglixa @k8s-ci-robot @minikube-bot @RA489 @sharifelgamal @medyagh @tstromberg